Skip to content

Tweak check_board_header.py to also validate the PSRAM settings#2924

Merged
will-v-pi merged 1 commit intopico-psramfrom
check_psram_settings
May 8, 2026
Merged

Tweak check_board_header.py to also validate the PSRAM settings#2924
will-v-pi merged 1 commit intopico-psramfrom
check_psram_settings

Conversation

@lurch
Copy link
Copy Markdown
Contributor

@lurch lurch commented May 6, 2026 •
edited
Loading

This relates to the changes in #2919 and is effectively a "sub-PR" of that one.

@lurch lurch requested a review from will-v-pi May 6, 2026 09:31
will-v-pi
will-v-pi reviewed May 6, 2026
View reviewed changes
Comment thread tools/check_board_header.py Outdated
will-v-pi
will-v-pi reviewed May 6, 2026
View reviewed changes
Comment thread tools/check_board_header.py
@lurch lurch force-pushed the check_psram_settings branch from 7cba72d to 7e8bb10 Compare May 6, 2026 11:49
@lurch
Copy link
Copy Markdown
Contributor Author

lurch commented May 6, 2026

PR updated, rebased and force-pushed.

@lurch
Copy link
Copy Markdown
Contributor Author

lurch commented May 6, 2026

Looking at 2afd108 , should I also update this to error if PICO_AUTO_DETECT_PSRAM_SIZE is set and PICO_PSRAM_CS_PIN is missing?

@lurch
Copy link
Copy Markdown
Contributor Author

lurch commented May 6, 2026

...although saying that, perhaps it makes sense to check for exists(PICO_PSRAM_CS_PIN) or exists(PICO_AUTO_DETECT_PSRAM_CS) rather than just exists(PICO_PSRAM_CS_PIN)? 🤔

@will-v-pi
Copy link
Copy Markdown
Contributor

will-v-pi commented May 6, 2026

I don't think there's a use case for PICO_AUTO_DETECT_PSRAM_CS in a board header, as if you know what board you're building for, you should know what pin CS is wired to - so I think just adding an error when PICO_AUTO_DETECT_PSRAM_SIZE is set and PICO_PSRAM_CS_PIN is missing is fine

@lurch lurch force-pushed the check_psram_settings branch from 7e8bb10 to 4c6c1a9 Compare May 6, 2026 13:15
@lurch
Copy link
Copy Markdown
Contributor Author

lurch commented May 6, 2026

so I think just adding an error when PICO_AUTO_DETECT_PSRAM_SIZE is set and PICO_PSRAM_CS_PIN is missing is fine

Done 👍

@lurch lurch mentioned this pull request May 6, 2026
Open
@kilograham kilograham added this to the 2.2.1 milestone May 7, 2026
@will-v-pi will-v-pi merged commit b3caac8 into pico-psram May 8, 2026
11 of 15 checks passed
@will-v-pi will-v-pi deleted the check_psram_settings branch May 8, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

Assignees

@will-v-pi will-v-pi

Labels

board settings

Projects

None yet

Milestone

2.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lurch @will-v-pi @kilograham